Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating debian/sid with the 0.10.0 release. #2449

Merged
merged 861 commits into from
Aug 3, 2015

Conversation

nicolasnoble
Copy link
Member

Let's bring debian/sid up to date with our latest 0.10.0 release, so we can actually build a debian package out of it.

murgatroid99 and others added 30 commits June 29, 2015 11:30
Add Bazel target for Objective-C proto-gRPC runtime
…p_check

Added pkg-config checking to Makefile where possible
Fix initial-server-metadata-merged-into-terminal-server-metadata bug.
Still missing:
- Caching of the already checked JWTs (although it could be done at an
  upper layer).
- Caching of the jwks_uri to avoid 2 roundtrips for each verification.
soltanmm and others added 18 commits July 9, 2015 14:06
Bumped Node.js package version to 0.10.0
If the TCP client connection alarm triggers close to the connection
deadline (but succeeds), the alarm shuts down the endpoint underneath
the existing transport... which is very bad for its health.
…t.xml

Eating the error code from run_test.py, as Jenkins now uses report.xm…
Handle settings frame making a stream writable
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@stanley-cheung
Copy link
Contributor

I am not sure if I am doing the right thing, but I think I found an issue.

I download the 0.10 release and rename it to mv release-0_10_0.tar.gz grpc_0.10.0.orig.tar.gz.

I then clone the nicolasnoble/sid branch and run dpkg-buildpackage -us -uc at the base directory and got this error

[C]       Compiling test/core/fling/server.c
[LD]      Linking bins/opt/fling_server
./libs/opt/libgrpc.a(json_token.o): In function `grpc_auth_json_key_destruct':
/usr/local/google/home/stanleycheung/grpc-release-0_10_0/src/core/security/json_token.c:167: undefi\
ned reference to `RSA_free'
./libs/opt/libgrpc.a(json_token.o): In function `grpc_auth_json_key_create_from_string':
/usr/local/google/home/stanleycheung/grpc-release-0_10_0/src/core/security/json_token.c:130: undefi\
ned reference to `BIO_s_mem'
...
/usr/local/google/home/stanleycheung/grpc-release-0_10_0/src/core/tsi/ssl_transport_security.c:1175\
: undefined reference to `SSL_get_servername'
/usr/local/google/home/stanleycheung/grpc-release-0_10_0/src/core/tsi/ssl_transport_security.c:1183\
: undefined reference to `SSL_set_SSL_CTX'
./libs/opt/libgrpc.a(ssl_transport_security.o): In function `init_openssl':
/usr/local/google/home/stanleycheung/grpc-release-0_10_0/src/core/tsi/ssl_transport_security.c:144:\
 undefined reference to `CRYPTO_set_id_callback'
collect2: error: ld returned 1 exit status
make: *** [bins/opt/fling_server] Error 1

So I just unzip the grpc_0.10.0.orig.tar.gz release archive and try to debug from there by running make test_c, which is where dpkg-buildpackage failed and I can reproduce the exact same error.

So looking at the Makefile, the variable OPENSSL_LIBS is not populated for this execution path. This causes LIBS_SECURE to be only dl, and then LDLIBS_SECURE to be just -ldl. If I hardcode LDLIBS_SECURE to -ldl -lssl -lcrypto, then I can get pass this error.

I do have pkg-config installed so I believe that's why the assignment of OPENSSL_LIBS got skipped over

Edit: LDFLAGS may also play a role here but I am unable to find a combination that works.

@nicolasnoble
Copy link
Member Author

Ping.

1 similar comment
@ctiller
Copy link
Member

ctiller commented Jul 30, 2015

Ping.

andrewpollock added a commit that referenced this pull request Aug 3, 2015
Updating debian/sid with the 0.10.0 release.
@andrewpollock andrewpollock merged commit a6b2b70 into grpc:debian/sid Aug 3, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Jan 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet