Add darwin_arm64 and darwin_arm64e to c-ares’ config settings #24872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
thii
force-pushed
the
add-darwin_arm64-and-darwin_arm64e-config_settings
branch
from
f7fc8f4
to
350b8d2
Compare
This fixes Bazel selecting the wrong source for `cares` when building with `--cpu=darwin_arm64` or `--cpu=darwin_arm64e` (it was selecting the source in the default condition, which is for Linux). We're having the same patch in Bazel (bazelbuild/bazel@1782f0a; it was using an older grpc release). Fixing this here so we can remove the patch in the next update.
thii
force-pushed
the
add-darwin_arm64-and-darwin_arm64e-config_settings
branch
from
350b8d2
to
0ced4f5
Compare
thii
changed the title
|
@apolcyn Friendly ping - could you take a look? |
apolcyn
added
release notes: yes
apolcyn
approved these changes
Dec 10, 2020
gnossen
approved these changes
Dec 10, 2020
|
I'll merge after tests complete |
|
tests are green |
|
Thanks! |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes Bazel selecting the wrong source for
careswhen buildingwith
--cpu=darwin_arm64or--cpu=darwin_arm64e(it was selecting thesource in the default condition, which is for Linux).
We're having the same patch in Bazel
(bazelbuild/bazel@1782f0a;
it was using an older grpc release). Fixing this here so we can remove
the patch in the next update.