Make --server_port optional in C++ interop client #25550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apolcyn
added
lang/c++
release notes: no
donnadionne
reviewed
Feb 25, 2021
test/cpp/interop/client_helper.cc
Outdated
| absl::GetFlag(FLAGS_server_host).c_str(), | ||
| absl::GetFlag(FLAGS_server_port)); | ||
|
|
||
| std::string host_port = absl::GetFlag(FLAGS_server_host); |
There was a problem hiding this comment.
why not just call this host instead of host_port?
There was a problem hiding this comment.
What do you think about server_uri? (changed to that)
Preferred that over "host" since host may sound like it includes only the hostname component of the uri
donnadionne
approved these changes
Feb 25, 2021
|
ios binary size: #25431 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to allow running the interop client against services that only require a hostname as the channel target.
Also motivated by b/181142141