Increase timeout for PHP and Ruby xds v3 tests #26168
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanley-cheung
added
lang/php
lang/ruby
release notes: no
YifeiZhuang
approved these changes
May 4, 2021
menghanl
approved these changes
May 5, 2021
menghanl
changed the title
ericgribkoff
approved these changes
May 6, 2021
|
Superceded by #26187 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that recently, after the
api_listener,forwarding_rule_port_match,forwarding_rule_default_port,metadata_filtertest cases got added, PHP and Ruby x3 tests are more likely to timed out withERROR: Aborting VM command due to timeout of 10800 seconds. <-- this is 180 minutes.Ruby v3 Dashboard: https://testgrid.corp.google.com/grpc-lb#gRPC%20Ruby%20xDS%20v3%20Master
PHP v3 Dashboard: https://testgrid.corp.google.com/grpc-lb#gRPC%20PHP%20xDS%20v3%20Master
Note how the timeout error started happening after those 4 new test cases were added on Apr 30.
Now the test suite is running up to 20 xds test cases sequentially (if all the test cases are implemented for the language. PHP is having 18. Ruby is having 19 now). There are lots of adding, deleting and waiting on GCP resources to be ready inside each of these test cases. We can't expect to be able to keep adding test cases while keeping the same timeout value in the kokoro job config.