Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated backoff to use absl::Random #27193

Merged
merged 4 commits into from Dec 2, 2021
Merged

Updated backoff to use absl::Random #27193

merged 4 commits into from Dec 2, 2021

Conversation

veblush
Copy link
Contributor

@veblush veblush commented Aug 30, 2021

#26479 & internal b/192110891

@veblush veblush added the release notes: no Indicates if PR should not be in release notes label Aug 30, 2021
@veblush
Copy link
Contributor Author

veblush commented Aug 30, 2021 •
edited

grpc_build_artifacts_multiplatform: passed except some python failures (python_dev_linux_x64_jessie and
python_dev_linux_x64_fedora23)
-> Filed abseil/abseil-cpp#1011

@veblush
Copy link
Contributor Author

veblush commented Aug 30, 2021 •
edited

grpc_aws_basictests_php: passed

@veblush
Copy link
Contributor Author

veblush commented Aug 31, 2021

Also some of iOS tests failed with the following error

   Headers/Public/abseil/absl/random/internal/pcg_engine.h:265:20: error: implicit conversion loses integer precision: 'uint64_t' (aka 'unsigned long long') to 'int' [-Werror,-Wshorten-64-to-32]
    return rotr(s, rotate);

This was referenced Sep 8, 2021
Merged
Closed
@veblush
Copy link
Contributor Author

veblush commented Nov 23, 2021

Abseil just got the new release now so let's re-hydrate this!

@veblush
Copy link
Contributor Author

veblush commented Nov 23, 2021 •
edited

grpc_build_artifacts_multiplatform: passed
grpc_aws_basictests_php: passed

@veblush veblush changed the title Absl::Random usage test with the latest abseil Updated backoff to use absl::Random Nov 24, 2021
@veblush veblush marked this pull request as ready for review November 24, 2021 22:59
@markdroth
Copy link
Member

This is a nice step toward #17891.

@veblush
Replace in-house rand with absl::Random for backoff (grpc#26463)
492393f 
* Replace in-house rand with absl::Random for backoff

* Run sanity

* Added bscrypt dependency
@veblush
Removed ABSL_RANDOM_HWAES_FLAGS
1c37f2a
@grpc-checks grpc-checks bot added bloat/none and removed bloat/low labels Dec 1, 2021
@veblush veblush merged commit 260145c into grpc:master Dec 2, 2021
@copybara-service copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label Dec 3, 2021
@tamird tamird mentioned this pull request Apr 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markdroth markdroth markdroth approved these changes

Assignees
No one assigned
Labels
bloat/none imported Specifies if the PR has been imported to the internal repository lang/core perf-change/none release notes: no Indicates if PR should not be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@veblush @markdroth