Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[objc] nsstring formatting fix for error.code #27662

Closed
wants to merge 31 commits into from
Closed

[objc] nsstring formatting fix for error.code #27662

wants to merge 31 commits into from

Conversation

dennycd
Copy link
Contributor

@dennycd dennycd commented Oct 8, 2021

causing compile error on arm device build

@dennycd dennycd added lang/ObjC platform/iOS release notes: no Indicates if PR should not be in release notes labels Oct 8, 2021
@dennycd dennycd mentioned this pull request Oct 8, 2021
Open
sampajano
sampajano approved these changes Oct 8, 2021
View reviewed changes
Copy link
Contributor

@sampajano sampajano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@dennycd
[objc] nsstring formatting fix for error.code
5803a49 
causing compile error on arm device build
@dennycd dennycd enabled auto-merge (squash) October 11, 2021 23:36
ctiller and others added 18 commits October 15, 2021 13:04
@ctiller @dennycd
Move metadata setting into HPackParser (grpc#27545)
e88e8ae 
* forward work to get append, limit check into parser

* further cleanup

* Remove chttp2_incoming_metadata_buffer

* Automated change: Fix sanity tests

* test fixes

* fix cronet

* wip

* first pass mementofication of parsing - libgrpc compiles

* further progress

* fixes

* fixes

* fix leak

* Automated change: Fix sanity tests

* fix leak

* fixes

* x

* improve fuzzer

* init ordering fix

* Update hpack_parser_table.h

* Update hpack_parser.cc

* Update hpack_parser_test.cc

* Automated change: Fix sanity tests

* Automated change: Fix sanity tests

* i mustache myself why

* fix use after free

* Automated change: Fix sanity tests

* fixes

* eliminate second pass metadata - this is an illegal frame and fails the new parser

* handle mementos with size > sizeof(intptr_t)

* fix

* add parsed metadata header, test

* Automated change: Fix sanity tests

* fix includes

* phase1

* phase2

* Update parsed_metadata.h

* fix

Co-authored-by: ctiller <ctiller@users.noreply.github.com>
@ctiller @dennycd
Revert "Move metadata setting into HPackParser (grpc#27545)" (grpc#27686
efd925a 
)

This reverts commit f57a1f7.
@yesudeep @dennycd
Upgrade re2 to fix broken template on gcc-11. (grpc#27511)
b09a99d 
* Upgrade re2 to fix broken template on gcc-11.

The fix to re2 was made here:
google/re2@0ceda87

* Use release 2021-09-01 of re2. SHA256 pending.

* Adds sha256 sum for re2 release.

* Update sha256 sum.

* Update submodule third_party/re2 to 8e08f47b11b413302749c0d8b17a1c94777495d5 (release 2021-09-01)

* Update the submodule sanity check.
@UVV-gh @dennycd
cmake: revert db88fb0 (grpc#27626)
e7ea319 
Fix regression introduced by previous commit. Original problem that
commit was trying to fix was solved by modification of grpc recipe in
meta-openembedded project repository

Fixes grpc#26857

Signed-off-by: Vyacheslav Yurkov <uvv.mail@gmail.com>
@howyi @dennycd
PHP: fix ChannelCredentials\createSsl parameter phpdocs to optional a…
814a35b 
…nd default null (grpc#27283)
@yashykt @dennycd
grpc_server_config_fetcher: Cleanup StartWatch - remove unnecessary a…
f38c53b 
…rgs (grpc#27663)

* grpc_server_config_fetcher: Cleanup StartWatch - remove unnecessary args

* Reviewer comments

* Avoid a channel args copy copy for the non server config fetcher case

* Fix args destruction
@drfloob @dennycd
Upgrade libuv to v1.37.0 (grpc#27684)
ca62fa7 
* Upgrade libuv to v1.42.0

Also eliminates some cruft from the node implementation from 5 years ago

* sanitize.sh added a blank line?? ok then.

* pin to libuv v1.37.0
@yashykt @dennycd
Move service config code out of client_client to its own target (grpc…
aad12b0 
…#27683)

* Move service config code out of client_client to its own target

* Fix BUILD

* Fix test build

* Reviewer comments

* Reviewer comments

* Automated change: Fix sanity tests

* Reviewer comments

Co-authored-by: yashykt <yashykt@users.noreply.github.com>
@coeuvre @dennycd
Remove redundent toolchain registrations in WORKSPACE (grpc#27674)
390641f
@ctiller @dennycd
Revert "Revert "Move metadata setting into HPackParser (grpc#27545)" (g…
35ddf16 
…rpc#27686)" (grpc#27688)

This reverts commit 0e6ced8.
@drfloob @dennycd
fix libuv dep hash (grpc#27704)
c2be953
@krestofur @dennycd
Add CRL Enabled Credentials to test folder (grpc#27678)
cc48935
@markdroth @dennycd
grpclb: implement subchannel caching (grpc#27657)
b54d541 
* grpclb: implement subchannel caching

* code review changes

* fix clang tidy

* code review changes
@markdroth @dennycd
start splitting up xds_end2end_test (grpc#27702)
8a7b45c 
* move test xDS server to its own library

* move xds_end2end_test to xds subdir, and refactor CountedService

* add TODO

* fix sanity
@markdroth @dennycd
upgrade xDS protos (grpc#27698)
f73e511
@ejona86 @dennycd
Add grpc-java 1.41.0 to client_matrix.py (grpc#27447)
d85f7cf
@ctiller @dennycd
update parameter change (grpc#27713)
7603d73
@markdroth @dennycd
Revert "start splitting up xds_end2end_test (grpc#27702)" (grpc#27725)
28d2d05 
This reverts commit 69a9782.
markdroth and others added 11 commits October 15, 2021 13:04
@markdroth @dennycd
switch to new location of TypedStruct and ORCA protos (grpc#27700)
1b5efe5 
* upgrade xDS protos

* switch to new location of TypedStruct and ORCA protos

* fix sanity
@ctiller @dennycd
Remove old backwards compatibility cronet compression workaround code (…
f4af116 
…grpc#27701)
@markdroth @dennycd
Revert "Revert "start splitting up xds_end2end_test (grpc#27702)" (gr…
9d7cc69 
…pc#27725)" (grpc#27726)

This reverts commit 9177c53.
@veblush @dennycd
C++ struct-ify httpcli/internal_request and credential_test/request_m…
02893c4 
…etadata_state (grpc#27618)

* httpcli.request

* credential tests request_metadata_state struct

* Update by review

* more c++ify

* fix asan error

* update by review

* Update by review 2

* Fix sanity test
@markdroth @dennycd
RLS LB policy (grpc#27352)
ccd9edb 
* RLS LB policy plugin implementation

* Add RLS tests

* rls proto

* generate projects

* Fix adding child policy to child policy map

* Fix issues

* Fix rotten bits

* generate projects

* revert some strange changes

* First batch of fixes

* second batch of addressing comments

* generate_projects

* 3rd batch of fixes

* generate_projects

* 4th batch of fix

* 5th batch of fix

* Empty commit to trigger github PR refresh

* Add insecure build

* generate project

* update picker in a closure

* mutex guard audit

* clang-format

* Aggregate child policy states

* Use OrphanablePtr on ChildPolicyOwner()

* More fixes on comments

* Remove include grpc_security from rls.cc

* Fix key builder test as we removed RlsFindPathFromMetadata

* Update rls proto and add multi-target capability

* code changes to fix build after merging master

* remove support for insecure builds

* WIP

* add LB policy metadata lookup API

* add API for creating errors from C++ strings

* add missing include

* finished updating JSON parsing

* use DualRefCounted<> for ChildPolicyWrapper

* use grpc_core::Mutex instead of std::recursive_mutex

* add lock annotations and fix some lifetime issues

* misc fixes and cleanups

* simplify child policy connectivity state machine

* add comment about hopping into ExecCtx

* don't use wait_for_ready for RLS call

* extraKeys and constantKeys support

* add lock annotations for child policy wrapper connectivity state

* improve logging

* simplify child policy state handling in picker

* use C++ style comments

* remove rls_config.proto, since it's not needed

* rewrote tests

* fix build

* fix copyright headers

* clang-format

* appease clang-tidy

* remove unnecessary dependendency on grpclb

* buildifier

* remove illegal term

* remove unneeded includes

* clang-format

* fix clang-tidy

* fix build

* move class declaration into .cc file

* clang-tidy again

* fix build

* reorganize code and misc cleanups

* clang-format

* fixed a bunch of asan bugs; still some left to debug

* fix asan problem

* make test work on IPv6-only machines

* move LRU list handling into Cache::Entry and add lock annotations

* use preincrement instead of postincrement

* fix deadlock

* add more FIXMEs

* clean up backoff timer logic

* fix build from merge

* clang-format

* fix include path to work on podspec builds

* clean up picker logic

* clang-format

* update rls.proto

* populate reason and stale_header_data in RLS request

* improve logging and fix some cache size type issues

* clang-format

* add some TODOs about a better way to expose channel creds to LB policies

* centralize handling of channel's default authority

* clang-format

* fix backup poller bug

* fix handling of call creds and authority on RLS channel

* remove unused params

* clang-format

* use two-phase update for child policies to avoid deadlocks

* fix portability issue

* minor cleanups

* update for change in grpc_error_get_status() API

* change test to store RLS requests and responses in proto form

* clang-format

* account for test slowdown factor in timeouts

* fix tsan failure and channelz linkage

* fix RLS authority death test

* fix test to not try to connect to target that should not work

* remove illegal term

* cacheSizeBytes is a required field

* add missing BUILD deps from merge

* add tests for connectivity state reporting and fix bugs found

* fix BUILD sanity

* buildifier

* fix BUILD package path

* fix bugs related to child policy lifetime and updates

* remove unnecessary srand() call from grpc_init()

* add test for two cache entries with the same target

* update rls.proto

* change RLS config parser test to support GRPC_ERROR_IS_ABSEIL_STATUS

* update upb codegen

* fix include path

* add env var guard

* avoid duplication of CountedService

* generate_projects

* add upper limit for cacheSizeBytes

* fix build

Co-authored-by: Muxi Yan <mxyan@google.com>
@veblush @dennycd
Add absl::Status support to lockfree_event & call_combiner (grpc#27362)
e0fb7c8 
* Add absl::Status support to lockfree_event & call_combiner

* Revert "Add absl::Status support to lockfree_event & call_combiner"

This reverts commit 7e68238.

* Use StatusAllocHeapPtr for call_combiner and lockfree_event

* Update by review
@dennycd
Add support for Workforce pool credentials (grpc#27583)
b5e6241 
* first commit

* Update external_account_credentials.cc

* Fix CI issues
@sifmelcara @dennycd
Update bazel version to 4.2.1 in binder_transport_apk docker image (g…
98b8128 
…rpc#27721)

This image is for testing binder transport Android APK build
@markdroth @dennycd
fix for import of RLS LB policy (grpc#27736)
eda542f
@ctiller @dennycd
Make hpack tracing available in opt builds also (grpc#27728)
832fdcf
@HannahShiSFB @dennycd
upgrade docker images (grpc#27705)
e48e4d3
@dennycd dennycd disabled auto-merge October 15, 2021 23:17
@dennycd dennycd closed this Oct 15, 2021
@dennycd dennycd mentioned this pull request Oct 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampajano sampajano Awaiting requested review from sampajano

@stanley-cheung stanley-cheung Awaiting requested review from stanley-cheung

Assignees
No one assigned
Labels
lang/ObjC platform/iOS release notes: no Indicates if PR should not be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet