Give make a long timeout, tests a small one, and interop a slightly longer one #2799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jcanizales - closed your PR in preference of this one |
| test_job = jobset.JobSpec( | ||
| cmdline=['tools/run_tests/run_interops_test.sh', '%s' % lang, '%s' % test], | ||
| shortname=test, | ||
| timeout_seconds=900) |
|
LGTM, but I'd prefer If you rebased. |
|
Let's see how we go with 2788 today... If there's time it'll get done. On Fri, Aug 7, 2015, 3:29 AM Jan Tattermusch notifications@github.com
|
|
Merged |
Conflicts: tools/run_tests/run_interops.py
jtattermusch
added a commit
that referenced
this pull request
Aug 14, 2015
Give make a long timeout, tests a small one, and interop a slightly longer one
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A more robust solution for #2785.
Builds upon #2788, which should be merged first.
The relevant commit here is db0d234