security: Refactor some utility functions in TSI for better internal use #29728
Conversation
…r_protect_flush`, and `ssl_protector_unprotect` to utility functions for internal use.
ZhenLian
changed the title
| @@ -1053,6 +1053,272 @@ void ssl_tsi_test_do_handshake_with_custom_bio_pair() { | |||
| tsi_test_fixture_destroy(fixture); | |||
| } | |||
|
|
|||
| absl::Status void do_handshake_helper(SSL** out_client, SSL** out_server) { | |||
There was a problem hiding this comment.
Is this function used anywhere?
There was a problem hiding this comment.
This is only used in ssl_transport_security_util_test.cc.
| std::size_t server_buffer_offset; | ||
| }; | ||
|
|
||
| TEST_P(FlowTest, TestWorkFlows) { |
There was a problem hiding this comment.
The names could be more specific here...what kind of flow are we testing? Roughly how do we execute our tests? You can put some comments above to make it more clear...
| /*writebuf2=*/0), | ||
| 1); | ||
| SSL_set_bio(server_ssl, server_ssl_bio, server_ssl_bio); | ||
|
|
There was a problem hiding this comment.
one small nit: can we please remove all the unnecessary blank spaces in this PR? If you intend the blank space to be a "logical breakpoint", you can add a comment explaining what the next block will do. Otherwise I think it's safe to just remove these blank spaces, and same thing for all the other files.
ZhenLian
added
lang/c++
area/security
kokoro:force-run
release notes: no
|
@markdroth Hi Mark, would you mind taking a second look at the style&semantics of this change? Thank you so much! |
They should be fixed now. |
copybara-service
bot
added
the
imported
Factor out the function body of
ssl_protector_protect,ssl_protector_protect_flush, andssl_protector_unprotectto utility functions for internal use.@ZhenLian