Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XdsClient: work around gcc bug in std::variant<> #30394

Merged
merged 3 commits into from
Jul 26, 2022
Merged

XdsClient: work around gcc bug in std::variant<> #30394

merged 3 commits into from
Jul 26, 2022
+134 −111

Conversation

markdroth
Copy link
Member

Fixes #30140.

@markdroth markdroth added the release notes: no Indicates if PR should not be in release notes label Jul 23, 2022
@markdroth markdroth requested a review from veblush July 23, 2022 11:19
@markdroth markdroth merged commit dc0fd42 into grpc:master Jul 26, 2022
@markdroth markdroth deleted the gcc_variant_workaround branch July 26, 2022 16:08
@copybara-service copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veblush veblush veblush approved these changes

Assignees
No one assigned
Labels
bloat/none imported Specifies if the PR has been imported to the internal repository lang/core per-call-memory/neutral release notes: no Indicates if PR should not be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Usage update of absl::variant in xds module to ensure better compatibility & simplicity
2 participants
@markdroth @veblush