-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Target Reorganization Part 1 #30518
Build Target Reorganization Part 1 #30518
Conversation
BUILD
Outdated
tags = ["nofixdeps"], | ||
visibility = ["@grpc:alt_gpr_base_legacy"], | ||
tags = [ | ||
"avoid_dep", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suspect we should remove the avoid_dep here... could you try and see whether fix_build_deps stays rational?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried, and I did not find anything change because of this tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do a trial import and see if there's any problems there before submitting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the goal is to eliminate gpr_base entirely, that will most definitely require a cherrypick since gpr_base is used in some places internally as well. Please confirm! Thanks!
6fe0eb2
to
653c295
Compare
a43239a
to
6a6b0c5
Compare
Given that we are removing codegen related files, we need to clean up the build targets in the current build file. There will be a series of PRs for this.
The new build targets should roughly follow this dependency graph.
Detailed steps is the following.
gpr_base
is merged intogpr
. Thegpr
here itself is nothing but depending ongpr_base
. I don't think we need to separate them.grpc++_internals
andgrpc++_internal_hdrs_only
are merged intogrpc++
. The reason is similar.grpc++
does not contain much stuff butgrpc++_internals
.gpr_codegen
is merged togpr
since the files ingpr_codegen
should be removed in the future and be moved togpr
.grpc_codegen
is merged togrpc_base
with the similar reason as above.grpc++_codegen_base
andgrpc++_codegen_base_src
are merged togrpc++_base
with the similar reason as above.grpc_secure
is merged togrpc
sincegrpc
is by default secure. We do not need to separate them.grpc++_base_unsecure
is merged either intogrpc++_base
or intogrpc++_unsecure
.This PR removes
gpr_base
and mergesgpr_codegen
intogpr
without removinggpr_codegen
for temporary compatibility. It should be removed in the following PRs.