Cmake add separate export for plugin targets #31525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a separate CMake export for the plugin targets to separate binaries and libraries into their own CMake target export files. Skip the cross compiled binary plugin targets during cross compile because they are not usable and not always available. The Yocto build system doesn't install cross compiled binaries into the target sysroot. This makes the CMake gRPC config useless as it checks the existent of binaries and fails without the binaries. This is a strip down version of grpc#22498 and related to grpc#26148 and grpc#26857. Signed-off-by: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com> Signed-off-by: Clément Péron <peron.clem@gmail.com>
jtattermusch
added
release notes: no
jtattermusch
approved these changes
Nov 7, 2022
There was a problem hiding this comment.
Seems fair. LGTM as long as all the tests pass.
I'd also like to get an opinion from @veblush before we merge.
grpc-checks
bot
added
per-call-memory/neutral
per-channel-memory/neutral
bloat/none
labels
copybara-service
bot
added
the
imported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a separate CMake export for the plugin targets to separate binaries
and libraries into their own CMake target export files. Skip the cross
compiled binary plugin targets during cross compile because they are not
usable and not always available.
The Yocto build system doesn't install cross compiled binaries into the
target sysroot. This makes the CMake gRPC config useless as it checks
the existent of binaries and fails without the binaries.
This is a strip down version of #22498 and related to #26148 and #26857.
@veblush @jtattermusch @herbrechtsmeier