-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[surface] Ensure SEND_STATUS & RECV_MESSAGE do not inhabit the same batch #31554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot inhabit the same batch
grpc-checks
bot
added
per-call-memory/neutral
per-channel-memory/neutral
bloat/none
labels
Nov 4, 2022
Automated fix for refs/heads/problem-children
ctiller
changed the title
[test] Ensure SEND_STATUS & (RECV_MESSAGE, RECV_CLOSE_ON_SERVER) do not inhabit the same batch
[surface] Ensure SEND_STATUS & RECV_MESSAGE do not inhabit the same batch
Nov 5, 2022
ctiller
added
the
release notes: no
Indicates if PR should not be in release notes
label
Nov 5, 2022
Automated fix for refs/heads/problem-children
gnossen
approved these changes
Nov 10, 2022
markdroth
approved these changes
Nov 10, 2022
stanley-cheung
approved these changes
Nov 10, 2022
copybara-service
bot
added
the
imported
Specifies if the PR has been imported to the internal repository
label
Nov 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bloat/none
imported
Specifies if the PR has been imported to the internal repository
lang/core
lang/php
lang/Python
lang/ruby
per-call-memory/neutral
per-channel-memory/neutral
release notes: no
Indicates if PR should not be in release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a check that SEND_STATUS_FROM_SERVER and RECV_MESSAGE are not in the same batch.
This is necessary pre-work for #31204 and implements part of grpc/proposal#336.
Also eliminates fling instead of updating it:
Tagging @markdroth for C/C++, @apolcyn for Ruby, @gnossen for Python, and @stanley-cheung for PHP changes.