Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[surface] Ensure SEND_STATUS & RECV_MESSAGE do not inhabit the same batch #31554

Merged
merged 22 commits into from
Nov 11, 2022

Conversation

ctiller
Copy link
Member

@ctiller ctiller commented Nov 4, 2022

Add a check that SEND_STATUS_FROM_SERVER and RECV_MESSAGE are not in the same batch.

This is necessary pre-work for #31204 and implements part of grpc/proposal#336.

Also eliminates fling instead of updating it:

  • My expectation is nobody has looked at this corner in many years
  • It's not a benchmark we want: concentrating on a microbenchmark that doesn't include a binding layer caused us to favor designs that emphasized a lightweight core at the expense of a expensive bindings. We should consider the whole.

Tagging @markdroth for C/C++, @apolcyn for Ruby, @gnossen for Python, and @stanley-cheung for PHP changes.

@ctiller ctiller changed the title [test] Ensure SEND_STATUS & (RECV_MESSAGE, RECV_CLOSE_ON_SERVER) do not inhabit the same batch [surface] Ensure SEND_STATUS & RECV_MESSAGE do not inhabit the same batch Nov 5, 2022
@ctiller ctiller added the release notes: no Indicates if PR should not be in release notes label Nov 5, 2022
@ctiller ctiller marked this pull request as ready for review November 10, 2022 05:02
@ctiller ctiller enabled auto-merge (squash) November 11, 2022 21:41
@ctiller ctiller enabled auto-merge (squash) November 11, 2022 21:42
@ctiller ctiller merged commit d410f1d into grpc:master Nov 11, 2022
@copybara-service copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bloat/none imported Specifies if the PR has been imported to the internal repository lang/core lang/php lang/Python lang/ruby per-call-memory/neutral per-channel-memory/neutral release notes: no Indicates if PR should not be in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants