New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ruby]: add pre-compiled binaries for ruby 3.2; drop them for ruby 2.6 #32089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apolcyn
added
release notes: yes
Indicates if PR needs to be in release notes
lang/ruby
labels
Jan 12, 2023
grpc-checks
bot
added
per-call-memory/neutral
per-channel-memory/neutral
bloat/none
labels
Jan 12, 2023
Currently macos unit tests are failing (where the ruby extension is built natively on the macos host i.e. not cross-compiled):
|
apolcyn
force-pushed
the
ruby_32_support
branch
from
January 13, 2023 06:02
f88d761
to
040b9c7
Compare
The
|
The macos issue is not reproducible locally |
stanley-cheung
approved these changes
Jan 19, 2023
apolcyn
added a commit
to apolcyn/grpc
that referenced
this pull request
Jan 19, 2023
grpc#32089) [ruby]: add pre-compiled binaries for ruby 3.2; drop them for ruby 2.6
This was referenced Jan 20, 2023
copybara-service
bot
added
the
imported
Specifies if the PR has been imported to the internal repository
label
Jan 20, 2023
@johnnyshields FYI this is available in 1.52.pre2 now |
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc
that referenced
this pull request
May 1, 2023
grpc#32089) [ruby]: add pre-compiled binaries for ruby 3.2; drop them for ruby 2.6
wanlin31
pushed a commit
that referenced
this pull request
May 18, 2023
#32089) [ruby]: add pre-compiled binaries for ruby 3.2; drop them for ruby 2.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bloat/none
imported
Specifies if the PR has been imported to the internal repository
lang/ruby
per-call-memory/neutral
per-channel-memory/neutral
release notes: yes
Indicates if PR needs to be in release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 3.2 came out at the end of 2022, and rake-compiler-dock just added support in 1.3.0. Ruby 2.6 is now EOL, so stop building pre-compiled targets for it.
Note:
Rakefile
by removing theif RUBY_PLATFORM =~ /darwin/
- we no longer build packages on macos hosts so there's no need for it.extconf.rb
to work around Regression when upgrading to 1.1.2 or greater: "make install" breaks gRPC native builds on certain macos CI jobs because ginstall corrupts the shared library rake-compiler/rake-compiler#210