[promises] Make Poll<T> its own type, not a variant<> #32515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
lang/C#
lang/c++
lang/core
lang/ObjC
lang/php
lang/Python
lang/ruby
labels
ctiller
added
release notes: no
grpc-checks
bot
added
per-call-memory/neutral
per-channel-memory/neutral
bloat/none
labels
markdroth
approved these changes
Mar 2, 2023
markdroth
changed the title
copybara-service
bot
added
the
imported
markdroth
pushed a commit
to markdroth/grpc
that referenced
this pull request
Mar 3, 2023
Avoids some compilation problems on older MSVC's, opens the door for some future optimizations. --------- Co-authored-by: ctiller <ctiller@users.noreply.github.com>
drfloob
added a commit
that referenced
this pull request
Mar 3, 2023
It seems as if we ran into this bug actions/labeler#442 on at least one PR #32515. This PR utilizes the suggested workaround until we can upgrade to a new major version release of actions/labeler.
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc
that referenced
this pull request
May 1, 2023
Avoids some compilation problems on older MSVC's, opens the door for some future optimizations. --------- Co-authored-by: ctiller <ctiller@users.noreply.github.com>
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc
that referenced
this pull request
May 1, 2023
…32542) It seems as if we ran into this bug actions/labeler#442 on at least one PR grpc#32515. This PR utilizes the suggested workaround until we can upgrade to a new major version release of actions/labeler.
wanlin31
pushed a commit
that referenced
this pull request
May 18, 2023
Avoids some compilation problems on older MSVC's, opens the door for some future optimizations. --------- Co-authored-by: ctiller <ctiller@users.noreply.github.com>
wanlin31
pushed a commit
that referenced
this pull request
May 18, 2023
It seems as if we ran into this bug actions/labeler#442 on at least one PR #32515. This PR utilizes the suggested workaround until we can upgrade to a new major version release of actions/labeler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids some compilation problems on older MSVC's, opens the door for some future optimizations.