-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "[core] Add support for vsock transport" #33276
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9d76586.
CC @YadongQi |
markdroth
approved these changes
May 30, 2023
drfloob
added
the
release notes: no
Indicates if PR should not be in release notes
label
May 30, 2023
copybara-service
bot
added
the
imported
Specifies if the PR has been imported to the internal repository
label
May 30, 2023
YadongQi
added a commit
to YadongQi/grpc
that referenced
this pull request
Jun 1, 2023
This reverts commit c5ade30.
eugeneo
pushed a commit
to eugeneo/grpc
that referenced
this pull request
Jun 1, 2023
Reverts grpc#32847. Breaks the Python build.
drfloob
added a commit
that referenced
this pull request
Jun 7, 2023
Revert "Revert "[core] Add support for vsock transport" (#33276)" This reverts commit c5ade30. And fix the issue which broke the python build. @markdroth @drfloob please review this PR. Thank you very much. --------- Co-authored-by: AJ Heller <hork@google.com>
mario-vimal
pushed a commit
to mario-vimal/grpc
that referenced
this pull request
Jun 15, 2023
Reverts grpc#32847. Breaks the Python build.
mario-vimal
pushed a commit
to mario-vimal/grpc
that referenced
this pull request
Jun 15, 2023
Revert "Revert "[core] Add support for vsock transport" (grpc#33276)" This reverts commit grpc@c5ade30. And fix the issue which broke the python build. @markdroth @drfloob please review this PR. Thank you very much. --------- Co-authored-by: AJ Heller <hork@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bloat/improvement
imported
Specifies if the PR has been imported to the internal repository
lang/core
per-call-memory/neutral
per-channel-memory/neutral
release notes: no
Indicates if PR should not be in release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #32847. Breaks the Python build.