-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[resolver and LB policy APIs] change address list to support multiple addresses per endpoint #33567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt_data_watcher_new
…nt_data_watcher_new
…nt_data_watcher_new
…nt_data_watcher_new
…nt_data_watcher_new
…stack_slaying_godwin
This was referenced Sep 28, 2023
copybara-service
bot
added
the
imported
Specifies if the PR has been imported to the internal repository
label
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bloat/low
imported
Specifies if the PR has been imported to the internal repository
lang/c++
lang/core
per-call-memory/neutral
per-channel-memory/neutral
release notes: no
Indicates if PR should not be in release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More changes as part of the dualstack design:
ServerAddress
withEndpointAddresses
, which encodes more than one address. Per-address channel args are retained at the same level, so they are now per-endpoint. For now,EndpointAddress
provides a single-address ctor and a single-address accessor for backward compatibility, soServerAdress
is an alias forEndpointAddresses
; eventually, this alias and the single-address methods will be removed.EndpointAddressSet
class, which represents an unordered set of addresses to be used as a map key. This will be used in a number of LB policies that need to store per-endpoint state.ChannelControlHelper::CreateSubchannel()
method to take the address and per-endpoint channel args as separate parameters, so that we don't need to construct a legacyServerAddress
object as we create a new subchannel for each address in the endpoint.EndpointAddressSet
as the key for its endpoint map, and to use the first address of the endpoint as the hash key.EndpointAddressSet
as the key for its endpoint weight map.Note that support for multiple addresses per endpoint is guarded in RR by the existing
round_robin_delegate_to_pick_fist
experiment and in WRR by the existingwrr_delegate_to_pick_first
experiment.This PR does not include support for multiple addresses per endpoint for the outlier_detection or xds_override_host LB policies; those will come in subsequent PRs.