Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ruby] remove unnecessary background thread startup wait logic that interferes with forking #33805

Merged
merged 2 commits into from Jul 24, 2023

Conversation

apolcyn
Copy link
Contributor

@apolcyn apolcyn commented Jul 21, 2023

Alternative to #33804 - this takes the approach in #33804 (comment)

Fix #33802

cc @casperisfine

@apolcyn apolcyn marked this pull request as ready for review July 21, 2023 19:14
@byroot
Copy link
Contributor

byroot commented Jul 21, 2023

Thanks, I'll test it Monday.

@casperisfine
Copy link
Contributor

I'll test it Monday.

feel free to merge if you are confident with the fix though.

Copy link
Contributor

@sampajano sampajano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay red CL! :)

@apolcyn apolcyn merged commit 7c21997 into grpc:master Jul 24, 2023
60 of 62 checks passed
apolcyn added a commit to apolcyn/grpc that referenced this pull request Jul 24, 2023
@copybara-service copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label Jul 25, 2023
apolcyn added a commit that referenced this pull request Jul 25, 2023
…wait logic that interferes with forking #33805" to v1.57.x (#33846)

Backports #33805
mario-vimal pushed a commit to mario-vimal/grpc that referenced this pull request Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bloat/none imported Specifies if the PR has been imported to the internal repository lang/ruby per-call-memory/neutral per-channel-memory/neutral release notes: yes Indicates if PR needs to be in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Ruby] v1.57.0-alpha race condition in GRPC.postfork_parent leading to an assertion crash
4 participants