[round_robin] 4th attempt: delegate to pick_first as per dualstack design #34337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s per dualstack design" (grpc#34335)" This reverts commit 6534f0a.
markdroth
added
the
release notes: no
markdroth
requested review from
jtattermusch,
veblush and
gnossen
as code owners
ctiller
approved these changes
Sep 13, 2023
grpc-checks
bot
added
bloat/medium
per-call-memory/neutral
per-channel-memory/neutral
labels
copybara-service
bot
added
the
imported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most recent attempt was #34320, reverted in #34335.
The first commit here is a pure revert. The second commit fixes the outlier_detection unit test to pass both with and without the experiment.