[deps] Upgrade protobuf version to v25.0 #34513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acozzette
changed the title
|
@veblush What are the next steps to get the full suite of tests to run against this change? |
grpc-checks
bot
added
per-call-memory/neutral
per-channel-memory/neutral
bloat/none
labels
veblush
added
kokoro:run
release notes: no
acozzette
force-pushed
the
upb
branch
2 times, most recently
from
b59a540
to
a923292
Compare
This includes deleting the obsolete .upb.c files and renaming upb-generated to upb-gen.
veblush
requested review from
jtattermusch,
apolcyn,
veblush and
gnossen
as code owners
veblush
approved these changes
Nov 10, 2023
grpc-checks
bot
added
per-call-memory/decrease
and removed
per-call-memory/increase
labels
|
This needs another cut back. |
This was referenced Nov 10, 2023
veblush
added a commit
that referenced
this pull request
Nov 10, 2023
To mitigate the following windows long path issue found in #34513. Using `pyb` instead of `python_build` saves 9 characters. --- `Distribution Tests Python Windows` failed because of `T:\altsrc\github\grpc\workspace_python_windows_x86_Python38_32bit\python_build\\temp.win-amd64-cpython-312\\Release\\src\core\ext\upb-gen\envoy\extensions\load_balancing_policies\client_side_weighted_round_robin\v3\client_side_weighted_round_robin.upb_minitable.obj`
grpc-checks
bot
added
per-call-memory/neutral
and removed
per-call-memory/decrease
labels
eugeneo
pushed a commit
to eugeneo/grpc
that referenced
this pull request
Nov 14, 2023
To mitigate the following windows long path issue found in grpc#34513. Using `pyb` instead of `python_build` saves 9 characters. --- `Distribution Tests Python Windows` failed because of `T:\altsrc\github\grpc\workspace_python_windows_x86_Python38_32bit\python_build\\temp.win-amd64-cpython-312\\Release\\src\core\ext\upb-gen\envoy\extensions\load_balancing_policies\client_side_weighted_round_robin\v3\client_side_weighted_round_robin.upb_minitable.obj`
eugeneo
pushed a commit
to eugeneo/grpc
that referenced
this pull request
Nov 14, 2023
This commit upgrades gRPC to protobuf v25.0 and makes some fixes to account for upb changes. One major change is that upb has been merged into the protobuf repo, so we can now drop the separate `@upb` dependency. Another is that `.upb.c` files no longer exist and there are new `.upb_minitable.h` and `.upb_minitable.c` files. The longer filenames exceeded a Windows restriction, so to work around that I renamed the `upb-generated` directory to just `upb-gen`, and likewise for `upbdefs-generated`.
veblush
added
release notes: yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit upgrades gRPC to protobuf v25.0 and makes some fixes to account for upb changes. One major change is that upb has been merged into the protobuf repo, so we can now drop the separate
@upbdependency. Another is that.upb.cfiles no longer exist and there are new.upb_minitable.hand.upb_minitable.cfiles. The longer filenames exceeded a Windows restriction, so to work around that I renamed theupb-generateddirectory to justupb-gen, and likewise forupbdefs-generated.