Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[xds] C++ XdsServerBuilder Remove src/... header dependency from public header #34790

Merged
merged 2 commits into from Oct 25, 2023
Merged

[xds] C++ XdsServerBuilder Remove src/... header dependency from public header #34790

merged 2 commits into from Oct 25, 2023

Conversation

yashykt
Copy link
Member

@yashykt yashykt commented Oct 25, 2023

No description provided.

@yashykt yashykt changed the title [xds] C++ XdsServerBuilder public header should not include headers from src/... [xds] C++ XdsServerBuilder Remove src/... header dependency from public header Oct 25, 2023
@yashykt yashykt added the release notes: yes Indicates if PR needs to be in release notes label Oct 25, 2023
markdroth
markdroth approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@markdroth markdroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up!

For bonus points, it might be a good idea to add a presubmit check to ensure that nothing in the include tree includes anything in the src tree.

@yashykt
Copy link
Member Author

yashykt commented Oct 25, 2023

For bonus points, it might be a good idea to add a presubmit check to ensure that nothing in the include tree includes anything in the src tree.

will add one

@yashykt yashykt merged commit 2bc23f1 into grpc:master Oct 25, 2023
67 of 70 checks passed
@copybara-service copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markdroth markdroth markdroth approved these changes

Assignees
No one assigned
Labels
bloat/none imported Specifies if the PR has been imported to the internal repository lang/c++ per-call-memory/neutral per-channel-memory/neutral release notes: yes Indicates if PR needs to be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yashykt @markdroth