[ssl] Support Windows system roots. #34874
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic in this change is based on the snippet by @RayKoopa: grpc#25533 (comment) Tested manually via the Cloud KMS CNG provider (https://github.com/GoogleCloudPlatform/kms-integrations), which has been relying on manually setting the GRPC_DEFAULT_SSL_ROOTS_FILE_PATH environment variable.
matthewstevenson88
added
area/security
release notes: no
grpc-checks
bot
added
per-call-memory/neutral
and removed
per-call-memory/increase
labels
gtcooke94
reviewed
Nov 3, 2023
src/core/lib/security/security_connector/load_system_roots_windows.cc
Outdated
Show resolved
Hide resolved
src/core/lib/security/security_connector/load_system_roots_windows.cc
Outdated
Show resolved
Hide resolved
src/core/lib/security/security_connector/load_system_roots_windows.cc
Outdated
Show resolved
Hide resolved
grpc-checks
bot
added
per-call-memory/increase
and removed
per-call-memory/neutral
labels
grpc-checks
bot
added
per-call-memory/neutral
and removed
per-call-memory/increase
labels
markdroth
reviewed
Feb 9, 2024
src/core/lib/security/security_connector/load_system_roots_windows.cc
Outdated
Show resolved
Hide resolved
src/core/lib/security/security_connector/load_system_roots_windows.cc
Outdated
Show resolved
Hide resolved
src/core/lib/security/security_connector/load_system_roots_windows.cc
Outdated
Show resolved
Hide resolved
grpc-checks
bot
added
per-call-memory/increase
and removed
per-call-memory/decrease
labels
grpc-checks
bot
added
per-call-memory/neutral
and removed
per-call-memory/increase
labels
grpc-checks
bot
added
per-call-memory/decrease
and removed
per-call-memory/neutral
labels
gtcooke94
approved these changes
Feb 9, 2024
grpc-checks
bot
added
per-call-memory/neutral
and removed
per-call-memory/decrease
labels
grpc-checks
bot
added
per-call-memory/decrease
and removed
per-call-memory/neutral
labels
This was referenced May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is copied from #34276, since I did not have permissions to add commits to it. That PR has been verified to work (see the top-level description). This PR just makes the gRPC tests pass (e.g. adding includes, clang formatting).