New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[channel] canonify target and set channel arg in only one place #36134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markdroth
added
the
release notes: no
Indicates if PR should not be in release notes
label
Mar 15, 2024
yijiem
approved these changes
Mar 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Mark! Nice simplification.
grpc-checks
bot
added
per-call-memory/increase
and removed
per-call-memory/neutral
labels
Mar 18, 2024
markdroth
added
release notes: yes
Indicates if PR needs to be in release notes
and removed
release notes: no
Indicates if PR should not be in release notes
labels
Mar 18, 2024
eugeneo
pushed a commit
to eugeneo/grpc
that referenced
this pull request
Mar 18, 2024
…#36134) Channel target will now be reported in canonified form (e.g., in channelz). Closes grpc#36134 COPYBARA_INTEGRATE_REVIEW=grpc#36134 from markdroth:channel_target 22e49e7 PiperOrigin-RevId: 616911536
sergiitk
pushed a commit
to grpc/psm-interop
that referenced
this pull request
Mar 20, 2024
grpc core change: grpc/grpc#36134. ref b/330392836
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bloat/none
lang/core
lang/php
lang/Python
per-call-memory/increase
per-channel-memory/neutral
release notes: yes
Indicates if PR needs to be in release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Channel target will now be reported in canonified form (e.g., in channelz).