Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[channel] canonify target and set channel arg in only one place #36134

Closed
wants to merge 6 commits into from

Conversation

markdroth
Copy link
Member

@markdroth markdroth commented Mar 15, 2024

Channel target will now be reported in canonified form (e.g., in channelz).

@markdroth markdroth added the release notes: no Indicates if PR should not be in release notes label Mar 15, 2024
@markdroth markdroth requested a review from yijiem March 15, 2024 23:24
Copy link
Member

@yijiem yijiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mark! Nice simplification.

@markdroth markdroth added release notes: yes Indicates if PR needs to be in release notes and removed release notes: no Indicates if PR should not be in release notes labels Mar 18, 2024
@markdroth markdroth deleted the channel_target branch March 18, 2024 19:54
eugeneo pushed a commit to eugeneo/grpc that referenced this pull request Mar 18, 2024
…#36134)

Channel target will now be reported in canonified form (e.g., in channelz).

Closes grpc#36134

COPYBARA_INTEGRATE_REVIEW=grpc#36134 from markdroth:channel_target 22e49e7
PiperOrigin-RevId: 616911536
sergiitk pushed a commit to grpc/psm-interop that referenced this pull request Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants