-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging GPR_ASSERT #36457
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanvi-jagtap
added
the
release notes: no
Indicates if PR should not be in release notes
label
Apr 26, 2024
grpc-checks
bot
added
bloat/none
per-call-memory/neutral
per-channel-memory/neutral
labels
Apr 26, 2024
grpc-checks
bot
added
per-call-memory/decrease
and removed
per-call-memory/neutral
labels
Apr 26, 2024
grpc-checks
bot
added
per-call-memory/increase
and removed
per-call-memory/decrease
labels
Apr 26, 2024
JuneYan
approved these changes
Apr 26, 2024
grpc-checks
bot
added
per-call-memory/neutral
and removed
per-call-memory/increase
labels
Apr 28, 2024
grpc-checks
bot
added
per-call-memory/increase
and removed
per-call-memory/neutral
labels
Apr 28, 2024
grpc-checks
bot
added
per-call-memory/neutral
and removed
per-call-memory/increase
labels
Apr 28, 2024
grpc-checks
bot
added
per-call-memory/decrease
and removed
per-call-memory/neutral
labels
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bloat/none
lang/core
per-call-memory/decrease
per-channel-memory/neutral
release notes: no
Indicates if PR should not be in release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging GPR_ASSERT
Replacing GPR_ASSERT with absl CHECK.
These changes have been made using string replacement and regex.
Will not be replacing all instances of CHECK with CHECK_EQ , CHECK_NE etc because there are too many callsites. Only ones which are doable using very simple regex with least chance of failure will be replaced.
Given that we have 5000+ instances of GPR_ASSERT to edit, Doing it manually is too much work for both the author and reviewer.