Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log #36575

Closed
wants to merge 18 commits into from

Conversation

tanvi-jagtap
Copy link
Contributor

[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log

In this CL we are migrating from gRPCs own gpr logging mechanism to absl logging mechanism. The intention is to deprecate gpr_log in the future.

We have the following mapping

  1. gpr_log(GPR_INFO,...) -> LOG(INFO)
  2. gpr_log(GPR_ERROR,...) -> LOG(ERROR)
  3. gpr_log(GPR_DEBUG,...) -> VLOG(2)

Reviewers need to check :

  1. If the above mapping is correct.
  2. The content of the log is as before.

gpr_log format strings did not use string_view or std::string . absl LOG accepts these. So there will be some elimination of string_view and std::string related conversions. This is expected.

@tanvi-jagtap tanvi-jagtap added the release notes: no Indicates if PR should not be in release notes label May 10, 2024
@tanvi-jagtap tanvi-jagtap marked this pull request as ready for review May 10, 2024 04:14
@tanvi-jagtap tanvi-jagtap deleted the test_core_e2e_all branch May 11, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants