[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log #36595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanvi-jagtap
added
the
release notes: no
grpc-checks
bot
added
bloat/none
per-call-memory/neutral
per-channel-memory/neutral
labels
grpc-checks
bot
added
per-call-memory/increase
per-call-memory/neutral
and removed
per-call-memory/neutral
per-call-memory/increase
labels
grpc-checks
bot
added
per-call-memory/decrease
and removed
per-call-memory/neutral
labels
tanvi-jagtap
requested review from
yousukseung
and removed request for
ananda1066
yousukseung
reviewed
May 14, 2024
| @@ -59,7 +60,7 @@ | |||
| #include "src/core/lib/resource_quota/api.h" | |||
| #include "test/core/test_util/port.h" | |||
|
|
|||
| #define LOG_TEST(x) gpr_log(GPR_INFO, "%s", #x) | |||
| #define LOG_TEST(x) LOG(INFO) << #x | |||
There was a problem hiding this comment.
nit: can we remove this macro? I see there's no good point now that we have LOG(INFO).
There was a problem hiding this comment.
This is actually a very nice catch . Multiple files are doing this. I will address all files in a single PR.
Thanks for catching this.
😃
yousukseung
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log
In this CL we are migrating from gRPCs own gpr logging mechanism to absl logging mechanism. The intention is to deprecate gpr_log in the future.
We have the following mapping
Reviewers need to check :
gpr_log format strings did not use string_view or std::string . absl LOG accepts these. So there will be some elimination of string_view and std::string related conversions. This is expected.