Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[StatsPlugin] Fix use-after-free issue #36664

Closed
wants to merge 6 commits into from
Closed

[StatsPlugin] Fix use-after-free issue #36664

wants to merge 6 commits into from

Conversation

yashykt
Copy link
Member

@yashykt yashykt commented May 17, 2024

Fix #36663

@yashykt yashykt changed the title Fix [StatsPlugin] Fix use-after-free issue [StatsPlugin] Fix use-after-free issue May 17, 2024
@yashykt yashykt added the release notes: yes Indicates if PR needs to be in release notes label May 17, 2024
@yashykt yashykt requested a review from yijiem May 17, 2024 22:35
markdroth
markdroth reviewed May 17, 2024
View reviewed changes
Copy link
Member

@markdroth markdroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we craft a test that fails without this fix?

include/grpc/support/metrics.h Outdated Show resolved Hide resolved
yashykt added a commit to yashykt/grpc that referenced this pull request May 20, 2024
@yashykt
[StatsPlugin] Fix use-after-free issue (grpc#36664)
e9743e2 
Fix grpc#36663

Closes grpc#36664

COPYBARA_INTEGRATE_REVIEW=grpc#36664 from yashykt:StatsPluginFixUseAfterFree 107c341
PiperOrigin-RevId: 635555326
yashykt added a commit to yashykt/grpc that referenced this pull request May 20, 2024
@yashykt
[StatsPlugin] Fix use-after-free issue (grpc#36664)
9c1d0c2 
Fix grpc#36663

Closes grpc#36664

COPYBARA_INTEGRATE_REVIEW=grpc#36664 from yashykt:StatsPluginFixUseAfterFree 107c341
PiperOrigin-RevId: 635555326
This was referenced May 20, 2024
Merged
Merged
yashykt added a commit that referenced this pull request May 21, 2024
@yashykt
[StatsPlugin] Fix use-after-free issue (#36664) (#36670)
979afe0 
Backport #36664 to 1.64.x
yashykt added a commit that referenced this pull request May 21, 2024
@yashykt
[StatsPlugin] Fix use-after-free issue (#36664) (#36669)
2b5eb25 
Backport #36664 to 1.63
@yashykt yashykt removed the lang/c++ label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yijiem yijiem yijiem approved these changes

@markdroth markdroth markdroth approved these changes

Assignees
No one assigned
Labels
bloat/none lang/core per-call-memory/neutral per-channel-memory/neutral release notes: yes Indicates if PR needs to be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use-after-free bug on StatsPluginChannelScope
3 participants
@yashykt @yijiem @markdroth