Factoring visual studio code into a buildgen plugin. #40
Conversation
| projects = [] | ||
| projects.extend(libs) | ||
| projects.extend(targets) | ||
| projects = [project for project in projects if project.get('vs_project_guid', None)] |
There was a problem hiding this comment.
This needs a comment - what is it doing
There was a problem hiding this comment.
Good question - I don't know :-D
This is me moving and de-duplicating code from @jtattermusch at that point. But I too was wondering what that was.
There was a problem hiding this comment.
Reverse engineering:
"select projects that have a vs_project_guid tag set"
There was a problem hiding this comment.
Figured it out actually. Tests don't have a guid because we don't want to create a project file for them.
There was a problem hiding this comment.
On Thu, Jan 22, 2015 at 5:25 PM, Nicolas Noble notifications@github.com
wrote:
In tools/buildgen/plugins/generate_vsprojects.py
#40 (comment):
- We want to help the work of the visual studio generators.
- """
- libs = dictionary.get('libs', [])
- targets = dictionary.get('targets', [])
- for lib in libs:
- lib['is_library'] = True
- for target in targets:
- target['is_library'] = False
- projects = []
- projects.extend(libs)
- projects.extend(targets)
- projects = [project for project in projects if project.get('vs_project_guid', None)]
Figured it out actually. Tests don't have a guid because we don't want to
create a project file for them.
Oh, yes that's the point. Sorry I didn't react to this right away.
—
Reply to this email directly or view it on GitHub
https://github.com/google/grpc/pull/40/files#r23426008.
|
Is this dead? |
|
No. Will do this during the week-end :-P On Fri, Jan 16, 2015 at 5:01 PM, Craig Tiller notifications@github.com
|
Conflicts: templates/vsprojects/vs2013/grpc.sln.template
|
Done. |
Factoring visual studio code into a buildgen plugin.
Add a dummy implementation of route_guide in c++.
Add PHP example to public auth doc
Make Node extension work with slice changes
Fix bug in JSON parsing when string value is a date
No description provided.