For GRPCOperation's, ensure finish _handler can only be called once #5893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and release it when called, so weak ptrs needn't be used with it, and the call won't be released until the finish handler is called. When the connectivityMonitor determines the connection has been lost, pull the host disconnect call. Creates an unreliable connection when connectivity is restored. Calling finishWithError: is sufficient.
makdharma
added a commit
that referenced
this pull request
Mar 22, 2016
For GRPCOperation's, ensure finish _handler can only be called once
jcanizales
added a commit
to jcanizales/grpc
that referenced
this pull request
Jun 27, 2016
That PR wasn’t tested nor reviewed adecuately.
jcanizales
added a commit
to jcanizales/grpc
that referenced
this pull request
Jun 28, 2016
That PR wasn’t tested nor reviewed adequately.
makdharma
added a commit
to makdharma/grpc
that referenced
this pull request
Jun 28, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release it when called, so weak ptrs needn't be used with it, and the call won't be released until the finish handler is called.
When the connectivityMonitor determines the connection has been lost, pull the host disconnect call. Creates an unreliable connection when connectivity is restored. Calling finishWithError: is sufficient.