Fix double delete #6354
Merged
Fix double delete #6354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -83,11 +83,15 @@ static void me_write(grpc_exec_ctx *exec_ctx, grpc_endpoint *ep, | |||
| if (m->parent->shutdown) { | |||
| ok = false; | |||
| } else if (m->on_read != NULL) { | |||
| gpr_slice_buffer_addn(m->on_read_out, slices->slices, slices->count); | |||
| for (size_t i = 0; i < slices->count; i++) { | |||
| gpr_slice_buffer_add(&m->read_buffer, gpr_slice_ref(slices->slices[i])); | |||
There was a problem hiding this comment.
the buffer has changed from m->on_read_out to m->read_buffer. Is this intentional?
|
h2_full+trace_test.exe high_initial_seqno is failing on windows. It seems a related issue (#5872) was closed yesterday though... |
|
That failure seems unrelated though. Labelling for merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6350