Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Idempotent endpoint shutdown #6911

Merged
merged 5 commits into from
Jun 17, 2016
Merged

Idempotent endpoint shutdown #6911

merged 5 commits into from
Jun 17, 2016

Conversation

ctiller
Copy link
Member

@ctiller ctiller commented Jun 15, 2016

No description provided.

@makdharma
Copy link
Contributor

@ctiller when this PR is checked in, do you see any other blockers for the PR #6283 ?

@ctiller
Copy link
Member Author

ctiller commented Jun 17, 2016

I don't think so.

@ctiller
Copy link
Member Author

ctiller commented Jun 17, 2016

This seems green enough, so just looking for an LGTM.

@ctiller
Copy link
Member Author

ctiller commented Jun 17, 2016

@sreecha - heads up - this subtly changes the contract for grpc_fd_shutdown to require it to be idempotent.

@makdharma
Copy link
Contributor

LGTM

@ctiller ctiller mentioned this pull request Jun 17, 2016
Merged
@jtattermusch jtattermusch merged commit fa1433a into grpc:master Jun 17, 2016
makdharma pushed a commit to makdharma/grpc that referenced this pull request Jun 20, 2016
Network status tracking
7981e19 
Recreated the old PR (grpc#6283) in a new
repo since the old repo was destroyed. Removed changes to tcp_posix.c
and tpc_windows.c, instead depending on the idempotent endpoint shutdown code
from grpc#6911.
@makdharma makdharma mentioned this pull request Jun 20, 2016
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jan 27, 2019
@lock lock bot unassigned sreecha and makdharma Jan 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes disposition/ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ctiller @makdharma @sreecha @googlebot @jtattermusch