Updated grpcio c extension build for windows to use mingw. #7012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default compiler for Python c extensions is VS2008 or VS2010 depending on the Python version. Since c-core moved onto the c99 standard, these compilers are not compatible.
|
Change content looks good but I'd like to learn a lot more from the commit log message. What went wrong since the last release that caused this to need to be revisited as part of this release? What was misunderstood between then and now and in what change? |
|
(Some of that information is already here as a pull request comment.) |
|
The pull request comment is straight from the commit message. The part that might be missing is "What was misunderstood between then and now and in what change", but I can't really point to a single commit because once we started with c99, there were a lot of offending changes. |
|
I saw that the first time I read the commit message; I don't know why I missed it the second time. My apologies. Luhguhtum. |
kpayson64
added a commit
to kpayson64/grpc
that referenced
this pull request
Jun 23, 2016
This is needed for building grpcio with mingw, see grpc#7012.
This was referenced Jun 23, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default compiler for Python c extensions is VS2008
or VS2010 depending on the Python version. Since c-core
moved onto the c99 standard, these compilers are not
compatible.