convert snake case protos package names to camel case in ruby modules #8265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
latest commit copies straight from protoc code |
murgatroid99
requested changes
Oct 3, 2016
| @@ -115,6 +115,50 @@ void PrintService(const ServiceDescriptor *service, const grpc::string &package, | |||
|
|
|||
| } // namespace | |||
|
|
|||
| grpc::string SnakeCaseToCamelCase(grpc::string input) { | |||
There was a problem hiding this comment.
You probably don't need this anymore, now that you have the other implementation.
| // foo_bar_baz -> FooBarBaz | ||
| std::string PackageToModule(const std::string& name) { | ||
| bool next_upper = true; | ||
| std::string result; |
There was a problem hiding this comment.
These should all be grpc::string, to be consistent with the rest of the code.
murgatroid99
approved these changes
Oct 4, 2016
|
test this please |
1 similar comment
|
test this please |
|
test failures here should be unrelated, merging |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First attempt to fix #8257.
Tested this with example protos files, tweaking the package names to use a similar pattern as used in the issue, and saw this work, but I think the c++ might need some tweaks.