-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Be a tad more specific requesting error reports #8663
Be a tad more specific requesting error reports #8663
Conversation
No matter how verbose this message is, there will continue to be "gRPC Broken" reports. But I think this is a good idea. |
Oh huh I forgot about this. |
e386134
to
e7bd4c2
Compare
472778c
to
791945c
Compare
Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure. |
1 similar comment
Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure. |
@kpayson64 @nathanielmanistaatgoogle do we still want to merge this? |
@mehrdada: yes I think so - may I trouble you to trigger what test runs need to happen? |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Closed in favor of #12713 |
Be a tad more specific requesting error reports (rebase #8663)
Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement. After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.
Regards, |
Can error reports end up obscenely long if people don't attach separate files? ... yes. Will it be quicker for all involved to just skim the logs? Probably usually yep.