Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be a tad more specific requesting error reports #8663

Conversation

soltanmm-google
Copy link
Contributor

Can error reports end up obscenely long if people don't attach separate files? ... yes. Will it be quicker for all involved to just skim the logs? Probably usually yep.

@kpayson64
Copy link
Contributor

No matter how verbose this message is, there will continue to be "gRPC Broken" reports. But I think this is a good idea.

@soltanmm-google
Copy link
Contributor Author

Oh huh I forgot about this.

@soltanmm-google soltanmm-google force-pushed the ballos-is-glados-what-a-tweeeeessstt branch from e386134 to e7bd4c2 Compare January 12, 2017 02:14
@soltanmm-google soltanmm-google force-pushed the ballos-is-glados-what-a-tweeeeessstt branch from 472778c to 791945c Compare January 23, 2017 16:39
@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

1 similar comment
@grpc-testing
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@mehrdada
Copy link
Member

mehrdada commented Aug 9, 2017

@kpayson64 @nathanielmanistaatgoogle do we still want to merge this?

@grpc grpc deleted a comment from grpc-kokoro Sep 26, 2017
@grpc grpc deleted a comment from grpc-kokoro Sep 26, 2017
@grpc grpc deleted a comment from grpc-testing Sep 26, 2017
@nathanielmanistaatgoogle
Copy link
Member

@mehrdada: yes I think so - may I trouble you to trigger what test runs need to happen?

@mehrdada
Copy link
Member

@nathanielmanistaatgoogle sure

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@mehrdada
Copy link
Member

mehrdada commented Sep 26, 2017

Closed in favor of #12713

@mehrdada mehrdada closed this Sep 26, 2017
kpayson64 added a commit that referenced this pull request Sep 26, 2017
Be a tad more specific requesting error reports (rebase #8663)
@lock lock bot locked as resolved and limited conversation to collaborators Jan 22, 2019
@lock lock bot unassigned mehrdada Jan 22, 2019
@thelinuxfoundation
Copy link

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

Regards,
CLA GitHub bot

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants