Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bin helpers: Various fixes to support --mode gamma and app_net #81

Merged
merged 15 commits into from
May 23, 2024

Conversation

sergiitk
Copy link
Member

@sergiitk sergiitk commented May 6, 2024

No framework code changed, just the bin scripts.

Tested with:

# Legacy
export PSM_EXTRA_FLAGS="--resource_suffix=legacy --server_xds_port=4343"
# mTLS
export PSM_EXTRA_FLAGS="--mode=secure --security=mtls --resource_suffix=mtls --server_xds_port=4545"
# AppNet
export PSM_EXTRA_FLAGS="--mode=app_net --resource_suffix=appnet --server_xds_port=4242"
# Gamma
export PSM_EXTRA_FLAGS="--mode=gamma --resource_suffix=gamma-http"
# Gamma GRPCRoute
export PSM_EXTRA_FLAGS="--mode=gamma --resource_suffix=gamma-grpc --gamma_route_kind=grpc"

Normal, AppNet setup

./run.sh bin/run_test_server.py \
  && ./run.sh bin/run_td_setup.py \
  && ./run.sh bin/run_td_setup.py --cmd=backends-add \
  && ./run.sh bin/run_test_client.py \
  && ./run.sh bin/run_ping_pong.py

CSM setup

./run.sh bin/run_test_server.py \
  && ./run.sh bin/run_test_client.py \
  && ./run.sh bin/run_ping_pong.py

@jarias-lfx
Copy link

/easycla

@sergiitk sergiitk force-pushed the bin-helpers-upd branch 2 times, most recently from e7569e4 to 21d1c54 Compare May 14, 2024 18:31
@sergiitk sergiitk force-pushed the bin-helpers-upd branch 3 times, most recently from db81d3a to 360e3fa Compare May 21, 2024 21:21
@sergiitk sergiitk changed the title bin helpers: Various fixes to support --mode=gamma bin helpers: Various fixes to support --mode gamma and app_net May 21, 2024
@sergiitk sergiitk marked this pull request as ready for review May 23, 2024 20:01
Copy link
Collaborator

@XuanWang-Amos XuanWang-Amos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sergiitk sergiitk merged commit 2727484 into grpc:main May 23, 2024
7 checks passed
@sergiitk sergiitk deleted the bin-helpers-upd branch May 23, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants