Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GRPCRoute baseline test #85

Merged
merged 3 commits into from
May 21, 2024
Merged

Add GRPCRoute baseline test #85

merged 3 commits into from
May 21, 2024

Conversation

sergiitk
Copy link
Member

@sergiitk sergiitk commented May 21, 2024

  • Add support for GAMMA GRPCRoute to the framework
  • And gamma_grpcroute_test - same sa gamma_baseline_test, but using GRPCRoute

Note for the reviewer: disable whitespace changes diff - most yaml changes is changing the indentation for readability.

@sergiitk sergiitk changed the title Add gamma_grpcroute_test test Add GRPCRoute baseline test May 21, 2024
@sergiitk
Copy link
Member Author

sergiitk commented May 21, 2024

@sergiitk
Copy link
Member Author

sergiitk commented May 21, 2024

gamma.gamma_grpcroute_test rerun after fixing the template:

@sergiitk sergiitk marked this pull request as ready for review May 21, 2024 20:22
@sergiitk
Copy link
Member Author

cc @gnossen

Copy link
Collaborator

@gnossen gnossen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. This is a nice increas in coverage!

framework/infrastructure/k8s.py Outdated Show resolved Hide resolved
@sergiitk
Copy link
Member Author

sergiitk commented May 21, 2024

@sergiitk sergiitk merged commit 6f4cfc0 into grpc:main May 21, 2024
7 checks passed
@sergiitk sergiitk deleted the csm-grpcroute branch May 21, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants