Resync pods after cache invalidation #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to gang schedule, the controller must invalidate the cache and determine the availability of the cluster using the current pods and nodes. In the previous version, the current pod list was not refreshed after the invalidation. This change reloads the pod list to avoid edge-case errors.
codeblooded
added
bug
paulosjca
approved these changes
Mar 29, 2021
paulosjca
added
release notes: yes
wanlin31
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to gang schedule, the controller must invalidate the cache and determine the availability of the cluster using the current pods and nodes. In the previous version, the current pod list was not refreshed after the invalidation. This change reloads the pod list to avoid edge-case errors.
Note: this issue has not yet been observed on the cluster. However, I noticed it could be problematic doing a walk-through of the controller code.