Add ESLInt and linting task to package

.eslintrc

@@ -0,0 +1,25 @@
+{
+    "env": {
+        "es6": true,
+    },
+    "extends": "airbnb-base",
+    "plugins": [
+        "import",
+    ],
+    "rules": {
+        "import/extensions": ["error", "always", { "js": "never", "mjs": "never" }],
+        "comma-dangle": ["error", "always-multiline"],
+        "quote-props": ["error", "consistent"],
+        "arrow-parens": "off",
+        "no-confusing-arrow": "off",
+        "no-nested-ternary": "off",
+        "implicit-arrow-linebreak": "off",
+        "arrow-body-style": "off",
+        "quotes": "off",
+        "import/order": "off",
+        "import/prefer-default-export": "off",
+        "no-script-url": "off",
+        "no-unused-vars": ["error", { "args": "none" }],
+        "object-curly-newline": "off",
+    }
+}

gulpfile.babel.js

@@ -1,3 +1,5 @@
+/* eslint-disable import/no-dynamic-require,global-require */
+
 import fs from 'fs';
 import path from 'path';
 import log from 'fancy-log';

lib/config.js

@@ -1,6 +1,5 @@
 import fs from 'fs';
 import path from 'path';
-import log from 'fancy-log';
 
 let parsedConfig;
 
@@ -12,24 +11,20 @@ const getParsedConfig = () => {
   return parsedConfig;
 };
 
-const convertDotStringToObject = (o, s) => {
-  s = s.replace(/\[(\w+)\]/g, '.$1'); // convert indexes to properties
-  s = s.replace(/^\./, '');           // strip a leading dot
-  var a = s.split('.');
-  for (var i = 0, n = a.length; i < n; ++i) {
-    var k = a[i];
-    if (k in o) {
-      o = o[k];
-    } else {
-      return;
+const convertDotStringToObject = (object, entryString) => {
+  // Convert indexes to properties, strip leading dot and create an array.
+  const entries = entryString.replace(/\[(\w+)\]/g, '.$1').replace(/^\./, '').split('.');
+  return entries.reduce((acc, entry) => {
+    if (acc && entry in acc) {
+      return acc[entry];
     }
-  }
-  return o;
+    return acc;
+  }, object);
 };
 
 const config = {
-  get(entry) {
-    return convertDotStringToObject(getParsedConfig(), entry);
+  get(entryString) {
+    return convertDotStringToObject(getParsedConfig(), entryString);
   },
 };
 

package.json

@@ -14,6 +14,7 @@
   ],
   "main": "gulpfile.babel.js",
   "scripts": {
+    "lint": "eslint . --ext=.js,.mjs",
     "test": "echo \"Not testing anything just yet.\" && exit 0"
   },
   "repository": {
@@ -37,9 +38,9 @@
     "browser-sync": "^2.18.13",
     "del": "^5.0.0",
     "dotenv": "^8.0.0",
-    "eslint": "^6.1.0",
+    "eslint": "^6.4.0",
     "eslint-config-airbnb-base": "^14.0.0",
-    "eslint-plugin-import": "^2.7.0",
+    "eslint-plugin-import": "^2.18.2",
     "fancy-log": "^1.3.2",
     "gulp": "^4.0.0",
     "gulp-better-rollup": "^4.0.1",

tasks/browsersync.js

@@ -1,5 +1,3 @@
-import config from '../lib/config';
-
 import browserSyncPackage from 'browser-sync';
 import { task } from 'gulp';
 

tasks/copy.js

@@ -12,11 +12,11 @@ export const copy = done => {
     log(`Skipping 'copy' task`);
     return done();
   }
-  pump([
+  return pump([
     src(config.get('tasks.copy'), {
       base: config.get('paths.src'),
     }),
-    dest(config.get('paths.dist'))
+    dest(config.get('paths.dist')),
   ], done);
 };
 

tasks/eslint.js

@@ -1,11 +1,10 @@
 import config from '../lib/config';
-import { isDevelopment } from '../lib/env';
 
 import log from 'fancy-log';
 import fs from 'fs';
 import path from 'path';
 import gulpEsLint from 'gulp-eslint';
-import { src, dest, task } from 'gulp';
+import { src, task } from 'gulp';
 
 const ESLINT_CONFIG = fs.existsSync('.eslintrc')
   ? '.eslintrc'

tasks/icons.js

@@ -15,14 +15,14 @@ export const icons = done => {
     log(`Skipping 'icons' task`);
     return done();
   }
-  pump([
+  return pump([
     src(config.get('tasks.icons.src')),
     svgmin((file) => ({
       plugins: [{
         cleanupIDs: {
-          prefix: path.basename(file.relative, path.extname(file.relative)) + '-',
+          prefix: path.basename(file.relative, `${path.extname(file.relative)}-`),
           minify: true,
-        }
+        },
       },
       {
         removeViewBox: false,

tasks/images.js

@@ -13,17 +13,17 @@ export const images = done => {
     log(`Skipping 'images' task`);
     return done();
   }
-  pump([
+  return pump([
     src(config.get('tasks.images.src')),
     imagemin([
       imagemin.jpegtran({
-        progressive: true
+        progressive: true,
       }),
       imagemin.svgo({
         plugins: [
           { removeViewBox: false },
-        ]
-      })
+        ],
+      }),
     ]),
     dest(config.get('tasks.images.dist')),
   ], done);

tasks/javascript-vendor.js

@@ -2,8 +2,6 @@ import config from '../lib/config';
 
 import log from 'fancy-log';
 import merge from 'merge-stream';
-import pump from 'pump';
-import gulpif from 'gulp-if';
 import concat from 'gulp-concat';
 import terser from 'gulp-terser';
 import { src, dest, task } from 'gulp';
@@ -31,15 +29,14 @@ export const jsvendor = done => {
           },
         }))
         .pipe(dest(entry.dist));
-    } else {
-      return src(entry.src)
-        .pipe(terser({
-          compress: {
-            drop_console: true,
-          },
-        }))
-        .pipe(dest(entry.dist));
     }
+    return src(entry.src)
+      .pipe(terser({
+        compress: {
+          drop_console: true,
+        },
+      }))
+      .pipe(dest(entry.dist));
   }));
 };
 

tasks/javascript.js

@@ -2,7 +2,6 @@ import config from '../lib/config';
 import { isDevelopment } from '../lib/env';
 
 import log from 'fancy-log';
-import fs from 'fs';
 import merge from 'merge-stream';
 import browserSync from 'browser-sync';
 import sourcemaps from 'gulp-sourcemaps';

tasks/modernizr.js

@@ -17,7 +17,7 @@ export const modernizr = done => {
     log(`Skipping 'modernizr' task`);
     return done();
   }
-  pump([
+  return pump([
     src([
       config.get('tasks.sass.src') || '',
       config.get('tasks.javascript.src') || '',

tasks/revision.js

@@ -32,7 +32,7 @@ const hashFiles = done => {
     log(`Skipping 'revision:hash' task for development`);
     return done();
   }
-  pump([
+  return pump([
     src([
       ...DEFAULTS,
       ...config.get('tasks.revision.files') || [],
@@ -53,7 +53,7 @@ const replaceCss = done => {
     log(`Skipping 'revision:css' task for development`);
     return done();
   }
-  pump([
+  return pump([
     src(`${config.get('tasks.sass.dist')}/**/*.css`),
     revReplace({ manifest: src(MANIFEST_FULL_PATH) }),
     dest(config.get('tasks.sass.dist')),
@@ -68,7 +68,7 @@ const replaceJs = done => {
     log(`Skipping 'revision:javascript' task for development`);
     return done();
   }
-  pump([
+  return pump([
     src(`${config.get('tasks.javascript.dist')}/**/*.js`),
     revReplace({ manifest: src(MANIFEST_FULL_PATH) }),
     dest(config.get('tasks.javascript.dist')),

tasks/sass-lint.js

@@ -5,7 +5,7 @@ import log from 'fancy-log';
 import fs from 'fs';
 import path from 'path';
 import gulpSassLint from 'gulp-sass-lint';
-import { src, dest, task } from 'gulp';
+import { src, task } from 'gulp';
 
 const LINT_CONFIG = fs.existsSync('.sass-lint.yml')
   ? '.sass-lint.yml'

tasks/sass.js

@@ -44,7 +44,7 @@ export const sass = done => {
     log(`Skipping 'sass' task`);
     return done();
   }
-  pump([
+  return pump([
     src(config.get('tasks.sass.main')),
     sassGlob(),
     gulpSass().on('error', error => {

tasks/watch.js

@@ -1,6 +1,5 @@
 import config from '../lib/config';
 
-import browserSyncPackage from 'browser-sync';
 import { task, watch, parallel, series } from 'gulp';
 
 import { browsersync } from './browsersync';

yarn.lock

@@ -2254,7 +2254,7 @@ eslint-module-utils@^2.4.0:
     debug "^2.6.8"
     pkg-dir "^2.0.0"
 
-eslint-plugin-import@^2.7.0:
+eslint-plugin-import@^2.18.2:
   version "2.18.2"
   resolved "https://registry.yarnpkg.com/eslint-plugin-import/-/eslint-plugin-import-2.18.2.tgz#02f1180b90b077b33d447a17a2326ceb400aceb6"
   integrity sha512-5ohpsHAiUBRNaBWAF08izwUGlbrJoJJ+W9/TBwsGoR1MnlgfwMIKrFeSjWbt6moabiXW9xNvtFz+97KHRfI4HQ==
@@ -2330,7 +2330,7 @@ eslint@^2.7.0:
     text-table "~0.2.0"
     user-home "^2.0.0"
 
-eslint@^6.0.0, eslint@^6.1.0:
+eslint@^6.0.0:
   version "6.2.2"
   resolved "https://registry.yarnpkg.com/eslint/-/eslint-6.2.2.tgz#03298280e7750d81fcd31431f3d333e43d93f24f"
   integrity sha512-mf0elOkxHbdyGX1IJEUsNBzCDdyoUgljF3rRlgfyYh0pwGnreLc0jjD6ZuleOibjmnUWZLY2eXwSooeOgGJ2jw==
@@ -2373,6 +2373,49 @@ eslint@^6.0.0, eslint@^6.1.0:
     text-table "^0.2.0"
     v8-compile-cache "^2.0.3"
 
+eslint@^6.4.0:
+  version "6.4.0"
+  resolved "https://registry.yarnpkg.com/eslint/-/eslint-6.4.0.tgz#5aa9227c3fbe921982b2eda94ba0d7fae858611a"
+  integrity sha512-WTVEzK3lSFoXUovDHEbkJqCVPEPwbhCq4trDktNI6ygs7aO41d4cDT0JFAT5MivzZeVLWlg7vHL+bgrQv/t3vA==
+  dependencies:
+    "@babel/code-frame" "^7.0.0"
+    ajv "^6.10.0"
+    chalk "^2.1.0"
+    cross-spawn "^6.0.5"
+    debug "^4.0.1"
+    doctrine "^3.0.0"
+    eslint-scope "^5.0.0"
+    eslint-utils "^1.4.2"
+    eslint-visitor-keys "^1.1.0"
+    espree "^6.1.1"
+    esquery "^1.0.1"
+    esutils "^2.0.2"
+    file-entry-cache "^5.0.1"
+    functional-red-black-tree "^1.0.1"
+    glob-parent "^5.0.0"
+    globals "^11.7.0"
+    ignore "^4.0.6"
+    import-fresh "^3.0.0"
+    imurmurhash "^0.1.4"
+    inquirer "^6.4.1"
+    is-glob "^4.0.0"
+    js-yaml "^3.13.1"
+    json-stable-stringify-without-jsonify "^1.0.1"
+    levn "^0.3.0"
+    lodash "^4.17.14"
+    minimatch "^3.0.4"
+    mkdirp "^0.5.1"
+    natural-compare "^1.4.0"
+    optionator "^0.8.2"
+    progress "^2.0.0"
+    regexpp "^2.0.1"
+    semver "^6.1.2"
+    strip-ansi "^5.2.0"
+    strip-json-comments "^3.0.1"
+    table "^5.2.3"
+    text-table "^0.2.0"
+    v8-compile-cache "^2.0.3"
+
 espree@^3.1.6:
   version "3.5.4"
   resolved "https://registry.yarnpkg.com/espree/-/espree-3.5.4.tgz#b0f447187c8a8bed944b815a660bddf5deb5d1a7"