Feature : Oracle integration #340
Conversation
|
Hi @badgerwithagun ! I have trouble to make the acceptance test with Oracle working. When i launch my tests inside IDE it's fine, when i make a Maven build, test is stuck in an inifite loop. Seems that -Doracle.jdbc.javaNetNio=false argument helped with the execution. Can't exactly figure why :( |
|
Build is failing because of missing javadoc on lombok generated code :( |
|
@badgerwithagun Any chance this nicely done PR will get an approval by this awesome project once failing checks are resolved? Thanks. |
|
Absolutely @skastenholz! If someone can fix the build I'll be happy to progress. I'll need to review it properly obviously |
|
Hey @RomainWilbert and @badgerwithagun, I provided the following PR RomainWilbert#4 to avoid the current build error. I assume it works this way. Otherwise please provide some guidance. Thanks. |
fix javadoc build error
|
@badgerwithagun As discussed the checks are fixed now. Please let us know if anything (else) prevents the merging of this PR. Thank you! |
|
Great stuff, thanks both! Merging. |
|
Thanks a lot for merging! I am wondering how and when it will be available after releasing 5.2.337 on Maven Central (https://mvnrepository.com/artifact/com.gruelbox/transactionoutbox-core) since https://github.com/gruelbox/transaction-outbox/actions/runs/4383418970 failed. |
|
Hi, @RomainWilbert I found that you have rewritten my previous fix for postgres, now the previous bug I fixed in this PR appears again.
|
Co-authored-by: Romain Wilbert <romain.wilbert-ext@pole-emploi.fr> Co-authored-by: skastenholz <stefan.kastenholz@gmail.com>
Implemented with Oracle-XE (gvenzl/oracle-xe:18-slim).