Fix LuaJIT build when LDFLAGS is defined #1667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LuaJIT dependency was failing to compile when
LDFLAGSwas defined in the command line. This was uncovered in the AUR package when changes to makepkg flags caused LDFLAGS to be set when building the package without explicitly disablingbuildoptions.My understanding is that when LDFLAGS is set, the incorrect options (
pkgconfig --libraries ...) were being picked up by the LuaJIT Makefile. This PR defines a separateLUAJIT_LDFLAGSvariable, initialized toLDFLAGS, but without the additional options added by the pcsx-redux build, which allows any host options (like the security flags set by Arch's makepkg) to still be passed to LuaJIT without breaking it.Please let me know if you have any feedback.
Thanks!