add minimize cache directory option

[e7h4n]

I added a cache for it because imagemin task is too slow.

[passy]

Those links have no definitions. :)

[passy]

Very cool, caching the results is definitely a good idea.

[sindresorhus]

I kinda wish grunt had this built-in, but I guess it's needed as this task can be slow.

Can you add a test to make sure it caches it?

And use os.tmpdir if available. (it's not available in node 0.8)

You also need to fix the merge conflict.

[e7h4n]

@sindresorhus Thanks, I'll write some test case. But I think system temp directory can be assigned in Gruntfile.js to keep task option concise like this:

imagemin: {
    option: {
        cache: path.resolve(os.tmpdir(), 'grunt-imagemin-cache')
    }
}

[sindresorhus]

@perfectworks i don't see the point of having an option when we can handle it automatically.

[sindresorhus]

ping

[sindresorhus]

ping

[e7h4n]

@sindresorhus I was in vacation last month, and will modify pull request this week.

[Antonio-Laguna]

ping? I wouldn't mind to do it but I came here every day to see if it's done 😄

[e7h4n]

Sorry for waiting, I've done testcase and use os.tmpdir to auto generate cache directory.

[sindresorhus]

I don't see any reason this should be an option. Caching can happen transparently.

[sindresorhus]

@perfectworks can you update regarding my comments and fix merge conflict? I want to merge this asap.

[sindresorhus]

ping

[e7h4n]

ping

[sindresorhus]

Thanks! Landed :)

🍰

[haggholm]

I've run into problems caused by this feature. Because it creates a dir under /tmp (well, os.tempdir, /tmp for me) with a deterministic name, this means that if multiple users on the same machine attempt to run imagemin, the path will clash. Since the permissions are 644 (again, for me -- this seems like a typical default), this means that the second user will get

Error: Unable to write "/tmp/grunt-contrib-imagemin.cache/9200eea54d49d30c49dcf749081098dddc844003" file (Error code: EACCES).

I suppose keeping the name consistent is a feature, not a bug (I'm guessing the point is to leave the temp files so they can be accessed as a cache), but then sharing a dirname between users becomes a problem. Perhaps the dir could include $USER?

(In my case I hit the problem because I run different sites under different users to separate security concerns. I can work around it by deleting the files from the corresponding accounts, or as root. It could be a major problem, though, for people building on shared hosting.)

[niftylettuce]

had the same issue

[sindresorhus]

@haggholm yup, sounds reasonable.

[juriejan]

A bit late, but this plugin might allow you guys to move out the caching functionality from this plugin:

https://github.com/tschaub/grunt-newer

[francishogue]

Having the same kind of problems as @haggholm and @niftylettuce.