Make relative reporterOutput paths optional #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just ran into this issue, could this be merged? Thank you. /cc @XhmikosR @vladikoff |
| @@ -156,7 +156,9 @@ exports.init = function(grunt) { | |||
| var reporterOutputDir; | |||
| // Get reporter output directory for relative paths in reporters | |||
| if (options.hasOwnProperty('reporterOutput')) { | |||
| reporterOutputDir = path.dirname(options.reporterOutput); | |||
| if(options.reporterOutputRelative) { | |||
vladikoff
added a commit
that referenced
this pull request
Jan 23, 2016
Make relative reporterOutput paths optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #202, making the reporter output filenames causes problems in some cases - in my specific usecase, I'm using the junit reporter, and putting the reporter output into a folder for use in CircleCI reporting.
This change adds the
reportOutputRelativeoption that can be set to false to disable the altering of paths to be relative.