Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs for preserveComments (CI failure appears unrelated) #431

Closed
wants to merge 1 commit into from
Closed

Update docs for preserveComments (CI failure appears unrelated) #431

wants to merge 1 commit into from

Conversation

cheshrkat
Copy link

  • Removed old options some and all
  • Added example on how to replicate license preservation (that some used to cover)

Update docs for preserveComments, removing old options and adding exa…
e078b23 
…mples on how to replicate license preservation
@cheshrkat
Copy link
Author

cheshrkat commented Aug 18, 2016 •
edited

Note the test breaking Travis also fails when I run it on master - not introduced by this change as far as I can tell.

@cheshrkat cheshrkat changed the title Update docs for preserveComments Update docs for preserveComments (CI failure appears unrelated) Aug 22, 2016
@Invis1ble
Copy link

Seems like function usage instead of 'some' doesn't works.

@cheshrkat
Copy link
Author

@Invis1ble worked when I tested it back in August. More-recent commits here or upstream may have changed something.

@XhmikosR XhmikosR closed this Oct 31, 2016
@XhmikosR XhmikosR reopened this Oct 31, 2016
@XhmikosR
Copy link
Member

@cheshrkat: feel free to fetch and rebase. Otherwise please close this.

@XhmikosR XhmikosR closed this Feb 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cheshrkat @Invis1ble @XhmikosR