Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where dependency variables reference and defaults were not being rendered #118

Merged
merged 3 commits into from Jul 18, 2022

Conversation

yorinasub17
Copy link
Contributor

Description

Fixes a bug that was introduced in #113 where the default and reference fields were no longer being rendered on direct variables definitions set on dependencies.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
    • NOTE: The release notes below does not mention that we no longer support bare variable definitions on dependencies config, primarily because this is already captured in the v0.5.0 release notes.

Release Notes (draft)

Fixed bug where the default and reference fields were no longer being rendered on direct variables definitions set on dependencies.

Copy link
Contributor

@zackproser zackproser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yorinasub17
Copy link
Contributor Author

Thanks for review! Merging now.

@yorinasub17 yorinasub17 merged commit a12ce6c into master Jul 18, 2022
@yorinasub17 yorinasub17 deleted the bug/variable-reference branch July 18, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants