Add for_each #134
Merged
Add for_each #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brikis98
requested review from
zackproser,
pete0emerson and
hongil0316
as code owners
…o/boilerplate into enhancement/hackday-for-each
|
OK, this is now ready for review. I added docs and examples; and by virtue of putting the examples and some test fixtures in the right folders, this also automatically adds tests. |
zackproser
reviewed
Jun 28, 2023
zackproser
previously approved these changes
Jun 28, 2023
brikis98
dismissed
zackproser’s stale review
The merge-base changed after approval.
marinalimeira
previously approved these changes
Jun 29, 2023
brikis98
dismissed
marinalimeira’s stale review
The merge-base changed after approval.
|
Hm, there seems to be some issue preventing me from merging. Might be related to: https://github.com/orgs/community/discussions/58535. The suggestion there is to close and re-open the PR... Let me try that. |
|
That... did not work. WTF. |
|
Grr, no time to deal with this, will temporarily disable branch protection and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
for_eachandfor_each_referencesupport to thedependencyblock ofboilerplate. If you pass in a list to these attributes, instead of creating thedependencyonce,boilerpaltewill loop over each item in thefor_eachlist, and run the dependency once for each of those items. You can access the current item in the loop using__each__.The main use case for this is to generate sub-folders and files dynamically: e.g., in https://github.com/gruntwork-io/prototypes/pull/361, I use this to generate environments (dev, stage, prod) dynamically, based on which environments the user asked for.
Bonus fix: remove Rho from CODEOWNERS; GitHub was showing an error about that.
TODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
Added / Removed / Updated [X].
Migration Guide