Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-188 rate limits #382

Merged
merged 2 commits into from
Dec 12, 2022
Merged

CORE-188 rate limits #382

merged 2 commits into from
Dec 12, 2022

Conversation

ellisonc
Copy link
Contributor

Description

Reduces the batch sizes on all resources where the AWS rate limits were a guess such that two instances of cloud nuke could be running on an account without expecting any issues. This should enable cloud-nuke to run better in automated environments as well as reduce the likelihood of manual activity in the AWS account interfering.

This is a stopgap solution to the rate limit issue and we plan to implement a more robust approach in the future.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

Release Notes (draft)

Updated max batch size on many resources to reduce rate limit errors.

Copy link
Contributor

@pete0emerson pete0emerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Stop-gap measure. Let's roll with it.

@ellisonc ellisonc merged commit 1cc8ad9 into master Dec 12, 2022
@ellisonc ellisonc deleted the feature/CORE-188-rate-limits branch December 12, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants