Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloud-nuke fixes #384

Merged
merged 2 commits into from
Dec 14, 2022
Merged

cloud-nuke fixes #384

merged 2 commits into from
Dec 14, 2022

Conversation

denis256
Copy link
Member

@denis256 denis256 commented Dec 13, 2022

Description

Noticed that cloud-nuke is not building now, failing with error:

# github.com/gruntwork-io/cloud-nuke/aws
aws/ec2_key_pair.go:4:2: imported and not used: "fmt"

Exited with code exit status 2

Found that AMI amzn-ami-hvm-2018.03.0.20220315.0-x86_64-gp2 used in tests is not available, updated to the latest supported version.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

@denis256 denis256 changed the title Imports cleanup cloud-nuke fixes Dec 13, 2022
Copy link
Contributor

@arsci arsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ellisonc ellisonc merged commit 3ffdc9f into master Dec 14, 2022
@ellisonc ellisonc deleted the imports-cleanup branch December 14, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants