Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more patterns to nuke #387

Merged
merged 2 commits into from
Dec 15, 2022

Conversation

Etiene
Copy link
Contributor

@Etiene Etiene commented Dec 15, 2022

Description

I noticed there were some more buckets accumulating in phx devops account that were not listed here. So I added some more patterns to this list. I don't know where some of these buckets are coming from because they are from repos I don't have access to, so please do a sanity check if this list seems reasonable.

Also added some log group tests that were not in the list.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

@pete0emerson pete0emerson self-requested a review December 15, 2022 14:52
Copy link
Contributor

@pete0emerson pete0emerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ellisonc ellisonc merged commit 8cb354a into gruntwork-io:master Dec 15, 2022
@Etiene Etiene deleted the etiene-bucket-patterns branch December 16, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants