Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ECR support #396

Merged
merged 8 commits into from
Jan 20, 2023
Merged

Implement ECR support #396

merged 8 commits into from
Jan 20, 2023

Conversation

zackproser
Copy link
Contributor

@zackproser zackproser commented Jan 19, 2023

Description

Fixes CORE-381.

cloud-nuke-ecr-demo

TODOs

Read the Gruntwork contribution guidelines.

  • Add tests
  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

@zackproser zackproser changed the title [WIP] Implement ECR support Implement ECR support Jan 20, 2023
Copy link
Contributor

@ellisonc ellisonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only thing I might add is a test for deleting repos with images, but I see you're using the force flag and that will be a case we manually exercise frequently when doing refarch testing so probably not worth the effort at this point.

@zackproser
Copy link
Contributor Author

zackproser commented Jan 20, 2023

Thanks for review! Going to merge this in once I see tests pass.

@zackproser zackproser merged commit 63d5755 into master Jan 20, 2023
@zackproser zackproser deleted the feature/support-ecr-repositories branch January 20, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants