Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-332 Document RDS, Neptune, Document DB #398

Merged
merged 4 commits into from
Jan 24, 2023
Merged

Conversation

ellisonc
Copy link
Contributor

Description

Fixes #389. Adds documentation for RDS db resource type and adds support for Config file filtering for DBInstance resources

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

Release Notes (draft)

Added DBInstance resource type support to config files.

Copy link
Contributor

@zackproser zackproser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ellisonc
Copy link
Contributor Author

re-running tests after enabling Macie in us-east-1, not sure how it got un-enabled but I want to keep the tests passing

@ellisonc ellisonc merged commit d4d042d into master Jan 24, 2023
@ellisonc ellisonc deleted the bugfix/CORE-332 branch January 24, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: "cloud-nuke aws --resource-type rds" doesn't only delete RDS DBs but also deletes documentDBs
2 participants