Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement nukeAllRdsDbSubnetGroups to delete all RDS subnet groups #472

Merged
merged 4 commits into from Jun 15, 2023
Merged

Implement nukeAllRdsDbSubnetGroups to delete all RDS subnet groups #472

merged 4 commits into from Jun 15, 2023

Conversation

hongil0316
Copy link
Contributor

@hongil0316 hongil0316 commented Jun 9, 2023 •
edited

Description

Fixes #471.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.
  • Attention Grunts - if this PR adds support for a new resource, ensure the nuke_sandbox and nuke_phxdevops jobs in .circleci/config.yml have been updated with appropriate exclusions (either directly in the job or via the .circleci/nuke_config.yml file) to prevent nuking IAM roles, groups, resources, etc that are important for the test accounts.

Release Notes (draft)

Added / Removed / Updated [X].
Added [Added a new resource DB Subnet Groups to cloud-nuke functionality]

Migration Guide

arsci
arsci reviewed Jun 13, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
aws/rds_subnet_group.go Outdated Show resolved Hide resolved
arsci
arsci approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@arsci arsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hongil0316 hongil0316 merged commit 8938011 into master Jun 15, 2023
2 of 3 checks passed
@hongil0316 hongil0316 deleted the rds_subnet_group branch June 15, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arsci arsci arsci approved these changes

@zackproser zackproser Awaiting requested review from zackproser

@pete0emerson pete0emerson Awaiting requested review from pete0emerson

@ellisonc ellisonc Awaiting requested review from ellisonc

@denis256 denis256 Awaiting requested review from denis256 denis256 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Deleting DB Subnet Groups for RDS
2 participants
@hongil0316 @arsci